Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2462 #2463

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fixes #2462 #2463

merged 1 commit into from
Mar 23, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

No description provided.

@privatenumber
Copy link
Contributor

Thanks for the quick fix 🙏

I was actually trying to debug the Zig code to see if I could identify where to fix myself so this is a great learning resource.

alexlamsl
alexlamsl approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@alexlamsl alexlamsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexlamsl alexlamsl merged commit 52d2765 into main Mar 23, 2023
@alexlamsl alexlamsl deleted the jarred/fixes-2462 branch March 23, 2023 13:49
cirospaciari pushed a commit that referenced this pull request Mar 31, 2023
@Jarred-Sumner @cirospaciari
Fixes #2462 (#2463)
5847274
@Neo00007 Neo00007 mentioned this pull request Mar 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlamsl alexlamsl alexlamsl approved these changes

Assignees

@alexlamsl alexlamsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarred-Sumner @privatenumber @alexlamsl